Skip to content

feat: add support for SharedArrayBuffer in DataViews#1714

Merged
legendecas merged 1 commit intonodejs:mainfrom
KevinEady:add-dataview-with-sharedarraybuffer
Mar 20, 2026
Merged

feat: add support for SharedArrayBuffer in DataViews#1714
legendecas merged 1 commit intonodejs:mainfrom
KevinEady:add-dataview-with-sharedarraybuffer

Conversation

@KevinEady
Copy link
Contributor

  • Add support for passing Napi::SharedArrayBuffer into Napi::DataView::New() overloads
  • Add DataView::Buffer()
  • Update docs and tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.54%. Comparing base (fe0c48e) to head (9c603b5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
napi-inl.h 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
+ Coverage   63.50%   63.54%   +0.04%     
==========================================
  Files           3        3              
  Lines        2047     2052       +5     
  Branches      728      729       +1     
==========================================
+ Hits         1300     1304       +4     
  Misses        162      162              
- Partials      585      586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Mar 13, 2026
@KevinEady KevinEady force-pushed the add-dataview-with-sharedarraybuffer branch from 87673ba to 8650813 Compare March 13, 2026 20:28
@KevinEady KevinEady force-pushed the add-dataview-with-sharedarraybuffer branch from 8650813 to 9c603b5 Compare March 20, 2026 14:08
@legendecas legendecas merged commit 7b8d69e into nodejs:main Mar 20, 2026
60 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants